for dnp3-python v0.2#5
Conversation
* added dnp3-primer to docs * added dnp3demo-module to docs and cleaned up demo scripts
kefeimo
requested review from
craig8 and
davidraker
and removed request for
craig8 and
davidraker
craig8
requested review from
bonicim,
craig8 and
shwethanidd
and removed request for
craig8 and
shwethanidd
craig8
left a comment
craig8
left a comment
There was a problem hiding this comment.
I am testing on 22.04 with the package from https://test.pypi.org/project/dnp3-python/0.2.3b2/. Though I could probably use the src and use setup.py for installation....Is that correct?
It seems that I couldn't get that to work. In the developer section of the readme can you walk us through the commands to build the project from source? This is different than normal so I would like to see that in the readme.
We need to be able to cross compile this on different versions of python. the output currently is https://test-files.pythonhosted.org/packages/43/1a/bef57863dee2ffacf467fba8912933b1b37fb30d0bca4a9c33380d2903e2/dnp3_python-0.2.3b2-cp38-cp38-manylinux1_x86_64.whl explicitly python3.8
| while count < 3: | ||
| sleep(1) # Note: hard-coded, master station query every 1 sec. | ||
| while count < 10: | ||
| sleep(2) # Note: hard-coded, master station query every 1 sec. |
There was a problem hiding this comment.
So tell me why we are sleeping here? Can we intercept something, or determine whatever startup (I assume startup) has to be done so we can continue?
There was a problem hiding this comment.
The sleep is to mimic the master polling interval, say, every 2 seconds.
When you say "Can we intercept something", do you mean Difference between gevent.sleep() and time.sleep() in Python? Since this is a small demo script, I intend to make it simple.
…ntu 22.04, python3.10
…uires, updated .gitmodules to pin pybind11
4 participants
No description provided.