Add new scripts to support Visma Connect apps #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smediavi
reviewed
Oct 14, 2022
Contributor
smediavi
left a comment
smediavi
left a comment
There was a problem hiding this comment.
Regarding the .gif examples: It could be better to place them somewhere generic if we don't want to create new ones for the visma developer portal examples. It could be misleading seeing the raet tenant id on the configuration.
| <AuthenticationTokenApiBaseUrl>https://api.raet.com/authentication</AuthenticationTokenApiBaseUrl> | ||
| </Services> | ||
|
|
||
| <Authentication> |
Contributor
There was a problem hiding this comment.
It could be confusing to have three places to configure the authentication. (Credentials, services, and this one.) Maybe this value can be included in one of the others, or be requested, the same as the ClientId and Secret.
Contributor
Author
There was a problem hiding this comment.
This setting has its own place to remarks that the tenant id is a different one and only for authentication purposes
smediavi
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.