Add RTL/bidi language support for Inky (fixes #122)#1
Merged
Conversation
Implement Unicode bidi preprocessing for Right-to-Left languages (Hebrew, Arabic, Persian, etc.) via a single-file bidify.js module that injects directional isolate markers (LRI/RLI/PDI). Integration points: - playerView.js: bidify() on story text before DOM - inkFile.js: stripBidi() before saving to disk - inklecate.js: bidifyJson() for compiled ink JSON export - appmenus.js: View > Bidify (RTL) submenu with 4 toggles - export-for-web: direction:rtl global tag support Test infrastructure: - 29 unit tests (bidify.js pure functions, 10 RTL scripts) - 7 app E2E tests via Playwright/Spectron launcher abstraction - 15 bidi E2E tests (Hebrew/Arabic typing, compile, playthrough) - Spectron compatibility patches for Electron 30 + Node 22 Documentation: - Architecture, sequence, data-flow, and test PUMLs - BIDIFIER_ARCHITECTURE.md - UI layout, menus, and workflow diagrams
VRDate
pushed a commit
that referenced
this pull request
Feb 27, 2026
Resolved conflicts from app/ → ink-electron/ rename: - package.json: merged test scripts (playwright launcher + incremental) - playerView.js: added setDirection export - docs/bidi/: accepted master's authoritative docs - app/test/test.js: removed (already in ink-electron/test/) - package-lock.json: accepted master's with spectron https://claude.ai/code/session_017wQBE8vrQVTgjg7rWgtYP6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement Unicode bidi preprocessing for Right-to-Left languages (Hebrew, Arabic, Persian, etc.) via a single-file bidify.js module that injects directional isolate markers (LRI/RLI/PDI).
Integration points:
Test infrastructure:
Documentation: