update icon paths within vscode source#440
Merged
stripedpajamas merged 1 commit intoVSCodium:masterfrom Jul 22, 2021
Merged
Conversation
Contributor
Author
Member
Merged
Contributor
Author
|
@stripedpajamas I think this will also solve the Windows icon, can you please check this in your dev env? |
Member
|
will do! |
Contributor
Author
|
Closing this, as Windows also seems to work according to comment in #413. Perhaps the workflow here can still help in future issues. |
Contributor
Author
|
Seeing as #582 reverted the logo change, I'll reopen this. @stripedpajamas please review against the current code base |
Member
|
Thanks for reopening, @Oekn5w. I will try building the PR against my branch and check the resulting Windows artifacts. |
Contributor
Author
|
@stripedpajamas What's the status on this? |
Member
|
Sorry for the long wait @Oekn5w -- I built your branch, just need to open it up on my Windows computer and we can merge this. |
Member
|
Confirmed the welcome icon is correct on Windows builds. Thanks @Oekn5w |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes (hopefully) #406
This is based on the git diff command in the
vscoderepositoryI don't have a development environment set up, I count on the PR build.
Edit:
git diffoutput for clarity with PR changes in --><--: