Skip to content

Conversation

@tynx
Copy link
Contributor

@tynx tynx commented Oct 15, 2018

each subfolder should/will be populated with version files...

this is a basic draft based on #41

each subfolder should/will be populated with version files...
@stripedpajamas
Copy link
Member

I am thinking that we will only support the stable release, as at least currently the whole build process works by looking at the latest tag on the MS repo. So I would say remove the insider folders from this PR.

Also, I don't think we will need to host the repo on Github pages. It should be that if the file is there (and updated at build time), then VSCodium could access it directly at https://github.com/vscodium/vscodium/master/api/update/{os}/stable/VERSION. So that part can be removed from the readme.

also the note about github-pages in the readme is gone.
Copy link
Member

@stripedpajamas stripedpajamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge after a couple of tweaks 👍

Thanks @tynx

By example of the api of MS itself (darwin/stable):
https://vscode-update.azurewebsites.net/api/update/darwin/stable/VERSION

The repo containing the version-json-files should have pages activated, see project settings. Instructions here: https://pages.github.com/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be removed (shouldn't need to use Github pages)

Suggested change
The repo containing the version-json-files should have pages activated, see project settings. Instructions here: https://pages.github.com/

@@ -0,0 +1,8 @@
# Faking the update-API of Microsoft

There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each version there is a subfolder. There should be a file in each of the folders called "VERSION" (uppercase).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each version there is a subfolder. There should be a file in each of the folders called "VERSION" (uppercase).
There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each platform there is a subfolder for the quality. There should be a file in each of the folders called "VERSION" (uppercase).

@JL2210
Copy link
Contributor

JL2210 commented Dec 27, 2018

@stripedpajamas You can commit directly to his repository if he's not responding.

@stripedpajamas
Copy link
Member

PR seems to be abandoned and more work needs to go into signing the build output before any updating API can be considered.

@stripedpajamas stripedpajamas reopened this May 2, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants