-
Notifications
You must be signed in to change notification settings - Fork 1.5k
add basic structure and explanation for fake api #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
each subfolder should/will be populated with version files...
|
I am thinking that we will only support the Also, I don't think we will need to host the repo on Github pages. It should be that if the file is there (and updated at build time), then VSCodium could access it directly at https://github.com/vscodium/vscodium/master/api/update/{os}/stable/VERSION. So that part can be removed from the readme. |
also the note about github-pages in the readme is gone.
stripedpajamas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge after a couple of tweaks 👍
Thanks @tynx
| By example of the api of MS itself (darwin/stable): | ||
| https://vscode-update.azurewebsites.net/api/update/darwin/stable/VERSION | ||
|
|
||
| The repo containing the version-json-files should have pages activated, see project settings. Instructions here: https://pages.github.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed (shouldn't need to use Github pages)
| The repo containing the version-json-files should have pages activated, see project settings. Instructions here: https://pages.github.com/ |
| @@ -0,0 +1,8 @@ | |||
| # Faking the update-API of Microsoft | |||
|
|
|||
| There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each version there is a subfolder. There should be a file in each of the folders called "VERSION" (uppercase). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each version there is a subfolder. There should be a file in each of the folders called "VERSION" (uppercase). | |
| There is a distinction between stable and insider for the "quality" of the version. Also there are three platforms: linux, win32 and darwin. For each platform there is a subfolder for the quality. There should be a file in each of the folders called "VERSION" (uppercase). |
|
@stripedpajamas You can commit directly to his repository if he's not responding. |
|
PR seems to be abandoned and more work needs to go into signing the build output before any updating API can be considered. |
each subfolder should/will be populated with version files...
this is a basic draft based on #41