Merged
Conversation
|
Looks good! I think that style and placement and language is fine. Thanks, @pgray64. |
|
@pgray64 Question: can we put these counts on the full item view as well? Somewhere around the Name, Size, and Format of the file? Sorry to expand the scope of the task last minute! |
Contributor
Author
|
@amandafrench Yep - that can be easily done since detail and simple views are in the same file. |
Contributor
Author
|
|
|
Thanks, @pgray64! |
Contributor
|
@pgray64, thank you -- nice job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download count is now present for each file listed in simple item view. Addresses issue #317.
I tested with various files and submissions with multiple files. Download count increases as expected.