Merged
Conversation
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
Users can now override the default 30-second HTTP timeout via --connection-timeout-seconds and --read-timeout-seconds. These options are available on all VWS commands and the Cloud Reco command, and are passed as a (connect, read) tuple to the underlying vws-python library. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
force-pushed
the
adamtheturtle/custom-timeouts
branch
from
3e99be1 to
b7f15fa
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| server_secret_key: str, | ||
| base_vws_url: str, | ||
| connection_timeout_seconds: float, | ||
| read_timeout_seconds: float, |
There was a problem hiding this comment.
Inconsistent keyword-only parameter marker across commands
Low Severity
This PR adds *, to enforce keyword-only arguments in get_target_record, get_duplicate_targets, get_target_summary_report, and delete_target, but list_targets and get_database_summary_report are missing the same *, marker. Every other command function in the file now uses keyword-only parameters, making these two inconsistent outliers.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--connection-timeout-secondsand--read-timeout-secondsCLI options to all VWS commands and Cloud Reco commandTest plan
Note
Low Risk
Low risk: additive CLI options and plumbing into existing client constructors with test coverage; main risk is unintended behavior change in request timeout handling across commands.
Overview
Adds per-command HTTP timeout customization to the CLI by introducing
--connection-timeout-secondsand--read-timeout-secondsoptions (defaults 30s, min 0.05s) and wiring them into all VWS commands and thevuforia-cloud-recoquery command viarequest_timeout_seconds=(connect, read).Updates generated help-text fixtures to document the new options and adds new tests that simulate delayed responses to verify smaller custom timeouts raise
requests.exceptions.Timeoutwhile larger values succeed.Written by Cursor Bugbot for commit b7f15fa. This will update automatically on new commits. Configure here.