fix: use Generator instead of Iterator for contextmanager return types#2163
Merged
adamtheturtle merged 1 commit intomainfrom Apr 24, 2026
Merged
fix: use Generator instead of Iterator for contextmanager return types#2163adamtheturtle merged 1 commit intomainfrom
adamtheturtle merged 1 commit intomainfrom
Conversation
Pyright 1.1.409 deprecates annotating `@contextmanager` return types as `Iterator[Foo]`; it now requires `Generator[Foo]`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@contextmanagerfunctions annotated withIterator[...]return types as deprecated. Switch them toGenerator[...]incommands.py,query.py, andvumark.py.Test plan
pyrightpasses locally on the three changed files🤖 Generated with Claude Code
Note
Low Risk
Low risk type-hint-only change across three CLI modules; no runtime behavior should change beyond static type checking.
Overview
Adjusts the three CLI exception-handling context managers (in
commands.py,query.py, andvumark.py) to returnGenerator[None]and updates imports accordingly, addressing Pyright’s deprecation warning forIterator[...]with@contextlib.contextmanager.Reviewed by Cursor Bugbot for commit 2c4d6fa. Bugbot is set up for automated code reviews on this repo. Configure here.