[codex] Upload Windows coverage data#3174
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows tests now upload their
.coverage.*artifact so the existing coverage combine job can include those results. Coverage is configured for subprocess collection and relative paths so xdist worker data from Windows can combine cleanly on Ubuntu. With Windows Docker coverage included, the Docker-specific# pragma: no coverannotations for Windows-only branches are removed. Validated with coverage config inspection, workflow linting, targeted Docker pytest without builds, pylint, custom linters, and the repository pre-commit/pre-push hooks.Note
Medium Risk
Moderate risk because it changes CI coverage collection/combining and could cause coverage gating failures or missing artifacts across Windows/Linux runs.
Overview
CI now includes Windows coverage in the overall 100% gate. The Windows workflow uploads
.coverage.*artifacts so the existingcoverage combinejob on Ubuntu can merge them.Coverage configuration is adjusted for cross-platform/xdist compatibility by enabling subprocess patching (
run.patch = ["subprocess"]) and using relative file paths (run.relative_files = true).Docker tests are updated to reflect the new coverage behavior by removing Windows-only
# pragma: no coversuppressions and tightening them to only exclude the truly unreachable assertion path.Reviewed by Cursor Bugbot for commit ab499ff. Bugbot is set up for automated code reviews on this repo. Configure here.