Implement test_invalid_target_type#2862
Merged
adamtheturtle merged 1 commit intomainfrom Feb 21, 2026
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
…hecking The test verifies that InvalidTargetTypeError is raised when attempting to generate a VuMark instance using credentials from a CloudDatabase (non-VuMark) database. This was previously a stub pending the mock implementation in vws-python-mock#2961. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
force-pushed
the
adamtheturtle/test-invalid-target
branch
from
d0c6538 to
a1855bd
Compare
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the stub test_invalid_target_type into a full integration test that validates InvalidTargetTypeError is raised when attempting to generate a VuMark instance using credentials from a CloudDatabase (non-VuMark) database. This addresses the TODO from vws-python-mock#2961 now that the mock properly enforces VuMark database type checking.
Test Plan
🤖 Generated with Claude Code
Note
Low Risk
Test-only change that adds coverage for an existing error case; no production code paths are modified.
Overview
Implements
test_invalid_target_typeas a real integration test that provisions aCloudDatabaseviaMockVWS, adds a standard target, and verifiesVuMarkService.generate_vumark_instanceraisesInvalidTargetTypeErrorwith HTTP 422 when used against a non-VuMark database.Written by Cursor Bugbot for commit a1855bd. This will update automatically on new commits. Configure here.