[codex] Switch httpx timeout handling to match#3011
Merged
Conversation
adamtheturtle
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the duplicated
isinstance(..., tuple)timeout branches in the sync and async HTTPX transports tomatchstatements.This keeps the timeout construction local to each transport while preserving tuple-specific connect/read values and scalar float/int behavior.
Closes #2960.
Validated with focused transport tests, full 100% coverage, and ruff, mypy, pyright, pyrefly, and ty checks.
Note
Low Risk
Low risk refactor limited to timeout construction in
HTTPXTransport/AsyncHTTPXTransport, with added tests covering integer timeouts to guard behavior.Overview
Refactors
HTTPXTransportandAsyncHTTPXTransporttimeout handling by replacing duplicatedisinstance(..., tuple)branching with amatchstatement that distinguishes(connect, read)tuples from scalar timeouts.Adds new sync/async transport tests to explicitly verify that integer
request_timeoutvalues are accepted and still produce successful requests.Reviewed by Cursor Bugbot for commit 7e3c00f. Bugbot is set up for automated code reviews on this repo. Configure here.