Ban dynamic builtins and typing.cast in lint config#3016
Merged
Conversation
Align pylint and ruff with literalizer: forbid bare filter, getattr, hasattr, map, and setattr via pylint, and ban typing.cast via ruff. Fix or exempt existing violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Note
Low Risk
Low risk since this only tightens Ruff/Pylint lint configuration, though it may cause new lint failures in downstream or future changes that rely on
typing.castor the banned builtins.Overview
Updates linting rules to disallow
typing.castimports via Ruff (flake8-tidy-imports) and to flag usage of certain dynamic builtins (filter,map,getattr,setattr,hasattr) via Pylint’sDEPRECATED_BUILTINS.bad-functionsconfiguration.Reviewed by Cursor Bugbot for commit 1ced42d. Bugbot is set up for automated code reviews on this repo. Configure here.