Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix AGA
BPLCON0bitplane count setup for viewports below 8 BPP.Previously, the AGA path in
viewLoad()always setBPU3(BV(4)) inBPLCON0. This makes hardware interpret the viewport as using an 8-bitplane mode even when the requested viewport depth is lower, e.g. 5 BPP. In practice this can result in a blank screen while the rest of the program continues running.This change sets
BPU3only when the requested bitplane count actually needs it.Details
(ubBpp & 0x07) << 12.BPU3only whenubBpp & 0x08is true.1-7 BPP) and8 BPP.Test
Tested with an AGA-enabled ACE project using a 5 BPP viewport on an A1200 FS-UAE configuration. Before the fix, palette updates and game logic worked, but bitmap/sprite output was blank. After the fix, graphics and sprites render correctly.