Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add proper AGA
FMODE=1/2data fetch setup forsimplebuffer.Details
Previously,
simplebufferonly special-casedFMODE=3, whileFMODE=1andFMODE=2still used the default ECS/OCS-style data fetch window. On AGA,FMODE=1/2use 32-bit bitplane fetches, so the data fetch stop position and scroll compensation need to differ fromFMODE=0.This change:
FMODE=1/2handling when calculatingDDFSTOP.FMODE=1/2, e.g. 320px lowres now resolves toDDFSTOP=$00c8instead of$00d0.simplebufferdisplays from 2-byte to 4-byte units.FMODE=0andFMODE=3behavior.Test
Tested with an AGA-enabled ACE project using a 320px lowres
simplebufferviewport inFMODE=1.Before the fix, the display was visibly skewed/blurred with diagonal line offsets. After the fix, the title/menu screen renders correctly.
Before
After