Feat: add deploy scripts#9
Merged
happenwah merged 2 commits intoValantisLabs:mainfrom Nov 2, 2024
Merged
Conversation
happenwah
reviewed
Nov 2, 2024
| protocolFactory.setSovereignPoolFactory(address(poolFactory)); | ||
|
|
||
| // Create ValidlyFactory | ||
| factory = new ValidlyFactory(address(protocolFactory), 1); |
Contributor
There was a problem hiding this comment.
This will always deploy a ValidlyFactory with 1 bips fee tier. Is this intentional, even for volatile pairs? If not, consider making it a function argument
Contributor
Author
There was a problem hiding this comment.
Okay I see a new factory is required for each new fee tier. Thanks for the heads up 👍
happenwah
reviewed
Nov 2, 2024
|
|
||
| poolFactory = new SovereignPoolFactory(); | ||
|
|
||
| protocolFactory.setSovereignPoolFactory(address(poolFactory)); |
Contributor
There was a problem hiding this comment.
protocol factory and sovereign pool factory only need to be deployed once per chain. Consider this when deploying in production.
Contributor
|
Thanks for the first official contribution king |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds foundry deploy scripts under the
scripts/folder.