Skip to content

Single-term optimization support for fully contracted tensor networks.#116

Merged
evaleev merged 1 commit intomasterfrom
sto-for-general-evaluation
Jul 12, 2023
Merged

Single-term optimization support for fully contracted tensor networks.#116
evaleev merged 1 commit intomasterfrom
sto-for-general-evaluation

Conversation

@bimalgaudel
Copy link
Member

No description provided.

///
/// returns a vector of Index objects that are common in @c idxs1 and @c idxs2.
///
/// @note I1 and I2 containers are assumed to be sorted by using
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this apply to common_indices also? if yes, update its docs. Complete docs ideally (copilot makes it easy)

end(i2vec), back_inserter(diffs),
Index::LabelCompare{});
return {commons, diffs};
/// T is integral type
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use proper dox tags instead of ad hoc format

Copy link
Member

@evaleev evaleev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the requested changes addressed in #117

@evaleev evaleev merged commit 6620d9e into master Jul 12, 2023
@evaleev evaleev deleted the sto-for-general-evaluation branch July 12, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants