Skip to content

resolve compilation issues in ast.hpp due to cyclic dep#163

Merged
evaleev merged 1 commit intomasterfrom
162-build-appleclang-150-c++20
Dec 2, 2023
Merged

resolve compilation issues in ast.hpp due to cyclic dep#163
evaleev merged 1 commit intomasterfrom
162-build-appleclang-150-c++20

Conversation

@evaleev
Copy link
Member

@evaleev evaleev commented Dec 1, 2023

No description provided.

@evaleev evaleev linked an issue Dec 1, 2023 that may be closed by this pull request
@evaleev evaleev merged commit c89a526 into master Dec 2, 2023
@evaleev evaleev deleted the 162-build-appleclang-150-c++20 branch December 2, 2023 00:01
@Krzmbrzl
Copy link
Collaborator

Krzmbrzl commented Dec 2, 2023

Where was the cyclic dependence and how does this solve it? Tome the diff looks like your commit mainly makes the constructors explicit 🤔

@evaleev
Copy link
Member Author

evaleev commented Dec 2, 2023

Where was the cyclic dependence and how does this solve it? Tome the diff looks like your commit mainly makes the constructors explicit 🤔

Definition NullaryValue was required to instantiate the Product ctor but NullaryValue was defined in terms of Sum so its definition was needed. Of course Sum also requires Product

@evaleev
Copy link
Member Author

evaleev commented Dec 2, 2023

not sure why C++20 triggered the complaint. Indeed might be a compiler issue actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[build] AppleClang 15.0, C++20

2 participants