Renaming SQL queries from GUI and improved Layout of SQL IDE#142
Renaming SQL queries from GUI and improved Layout of SQL IDE#142ValentinHerrmann merged 12 commits intomainfrom
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🧪 Test Results (Python 3.13)174 tests 174 ✅ 2s ⏱️ Results for commit b4794be. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the SQL IDE UI, adds inline rename/delete for SQL files, and adjusts server-side handling for user-defined SQL functions and the DB overview. It also introduces a new success/error banner for executed SQL and tweaks the layout of the SQL editor and results.
Changes:
- Minor cleanup in
overviewto standardize thecursor is Nonecheck. - Refactor of
user_functions_executeto wrap execution in a top-leveltry/exceptand return explicit HTTP 500 responses on errors. - SQL IDE layout and behavior updates: responsive two-pane layout, new success status banner, inline file actions (delete/rename), and restructured client-side logic in
sql_ide.js.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
tutorial/myapp/views/views.py |
Small readability fix in the overview view (if cursor is None:), no behavioral change. |
tutorial/myapp/views/user_functions.py |
Wraps user_functions_execute in a broad try/except, changes error handling to 500 text responses, and slightly changes control flow around when the execution view is rendered. |
tutorial/myapp/templates/sql_ide.html |
Reworks the SQL IDE layout into a flex-based split between file explorer and editor, adds a separate success banner, and wraps AJAX results in a styled container. |
tutorial/myapp/staticfiles/js/sql_ide.js |
Refactors from an IIFE to top-level functions, adds inline delete/rename buttons for files, refines save/run behaviors, introduces a success/error banner for query execution, and adjusts editor height behavior when showing results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…better separation of concerns and maintainability.
|
1 participant
closes #141