chore(slv-plugins): fix stale api/rpc-gateway/ doc references#387
Merged
Conversation
PR #386 deleted `api/rpc-gateway/` (the Deno gateway), but two doc comments still linked to that path: - `slv-plugins/README.md` linked the gateway as `../api/rpc-gateway`; retargeted to the in-workspace `./rpc-gateway` Rust crate. - `slv_transfers_plugin/src/lib.rs` pointed `transfer_type` numeric values "keep in sync with" the now-deleted `transfers.ts`; retargeted to the Rust handler at `slv-plugins/rpc-gateway/src/handlers/transfers.rs`. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #386 deleted
api/rpc-gateway/(the Deno gateway), but two doccomments in the slv-plugins crates still linked to that path. This
PR retargets both at the in-workspace Rust gateway.
Changes
slv-plugins/README.md— link../api/rpc-gateway→./rpc-gateway.slv-plugins/slv_transfers_plugin/src/lib.rs— `transfer_type`enum sync note now references
slv-plugins/rpc-gateway/src/handlers/transfers.rsinstead of the deleted
transfers.ts.No behaviour change.
Test plan
cargo check -p slv_transfers_plugin— clean