Skip to content

refactor: introduce SessionCtx to hold non-state-machine state#321

Merged
davidsteiner merged 3 commits intomainfrom
320-push-session-logic-into-state-variants
Mar 18, 2026
Merged

refactor: introduce SessionCtx to hold non-state-machine state#321
davidsteiner merged 3 commits intomainfrom
320-push-session-logic-into-state-variants

Conversation

@davidsteiner
Copy link
Member

@davidsteiner davidsteiner commented Mar 18, 2026

Group session context that doesn't change with the state machine into a single SessionCtx struct.

This will eventually allow us to pass the context borrowed from the session to session states so they can perform actions like manipulating the store and performing application callbacks.

@davidsteiner davidsteiner linked an issue Mar 18, 2026 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.91%. Comparing base (4fd0ad7) to head (ab38d4c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   90.90%   90.91%   +0.01%     
==========================================
  Files          88       88              
  Lines        8781     8799      +18     
==========================================
+ Hits         7982     8000      +18     
  Misses        799      799              
Flag Coverage Δ
core 90.78% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner merged commit d358f40 into main Mar 18, 2026
6 of 8 checks passed
@davidsteiner davidsteiner deleted the 320-push-session-logic-into-state-variants branch March 18, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Push session logic into state variants

2 participants