Skip to content

fix: prevent sessions from hanging due to lack of explicit shutdown and safeguards for TCP connection#347

Merged
davidsteiner merged 3 commits intomainfrom
344-session-can-hang-indefinitely-in-disconnectedreconnectfalse-when-peer-doesnt-close-tcp-socket
Apr 24, 2026
Merged

fix: prevent sessions from hanging due to lack of explicit shutdown and safeguards for TCP connection#347
davidsteiner merged 3 commits intomainfrom
344-session-can-hang-indefinitely-in-disconnectedreconnectfalse-when-peer-doesnt-close-tcp-socket

Conversation

@davidsteiner
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 92.55814% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.44%. Comparing base (9d4735d) to head (6eede11).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...rates/hotfix/src/transport/socket/socket_writer.rs 84.50% 11 Missing ⚠️
...rates/hotfix/src/transport/socket/socket_reader.rs 91.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   91.39%   91.44%   +0.04%     
==========================================
  Files          94       94              
  Lines        9554     9761     +207     
==========================================
+ Hits         8732     8926     +194     
- Misses        822      835      +13     
Flag Coverage Δ
core 91.33% <92.55%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidsteiner davidsteiner merged commit b32cdfe into main Apr 24, 2026
7 checks passed
@davidsteiner davidsteiner deleted the 344-session-can-hang-indefinitely-in-disconnectedreconnectfalse-when-peer-doesnt-close-tcp-socket branch April 24, 2026 08:40
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Session can hang indefinitely in Disconnected(reconnect=false) when peer doesn't close TCP socket

2 participants