KV3 Lib: unable to parse keys that have spaces in them

[RedMser]

Describe the bug

Note that I am using VRF as a library, not the Source2Viewer GUI.

This bug seems similar to #542 but this one is for reading KV3 data instead of writing.

If an object key has a space in it, parsing fails since ReadPropName searches for whitespace to end parsing, not taking into account that quoted strings may contain spaces.

Even if the spaces are removed, the quotes are also included in the resulting property name string.

Expected behavior

Parsing to complete without errors.

Relevant log output or exception with stacktrace

Exception has occurred: CLR/System.IO.InvalidDataException
An unhandled exception of type 'System.IO.InvalidDataException' occurred in ValveResourceFormat.dll: 'Unknown flag In"'
   at ValveResourceFormat.Serialization.KeyValues.KeyValues3.ReadValueFlagged(Char c, Parser parser) in /_/ValveResourceFormat/Serialization/KeyValues/KeyValues3.cs:line 446
   at ValveResourceFormat.Serialization.KeyValues.KeyValues3.ParseKVFile(Stream fileStream) in /_/ValveResourceFormat/Serialization/KeyValues/KeyValues3.cs:line 131

What game does this happen in

Deadlock

Reference file in a Source 2 game

Decompiled scripts/ping_wheel_messages.vdata_c contains strings like "Going In" as keys, which is correct as per #542 but does not parse properly by the lib's own parser.

What version of VRF are you using?

PackageReference Include="ValveResourceFormat" Version="10.2.3850"

[kristiker]

See ValveResourceFormat/ValveKeyValue#61, might be fixed in there.

[RedMser]

Thanks for letting me know about this. I'm currently doing a hacky workaround to parse this data somehow, but I'd like to fix this properly in the future.

I'll need to investigate whether that lib's KVObject type is compatible with VRF's, since I'm using this type all over the place.

Also this might be a good test case to add to that PR then, since it doesn't seem to be tested there currently! ^^

[kristiker]

It seems to have a test that has a key with delimiters in it.