proton: undo the effect of PYTHONSAFEPATH if any#9712
Open
Summertime wants to merge 2 commits intoValveSoftware:bleeding-edgefrom
Open
proton: undo the effect of PYTHONSAFEPATH if any#9712Summertime wants to merge 2 commits intoValveSoftware:bleeding-edgefrom
Summertime wants to merge 2 commits intoValveSoftware:bleeding-edgefrom
Conversation
with PYTHONSAFEPATH enabled: `['/var/lib/...', ...]` becomes `[PROTON_DIR, '/var/lib/...', ...]` without PYTHONSAFEPATH enabled: `[PROTON_DIR, '/var/lib/...', ...]` becomes `[PROTON_DIR, PROTON_DIR, '/var/lib/...', ...]` The double entry should have the same effect as a single entry (enabling relative imports) The relevant pieces in play: https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSAFEPATH https://docs.python.org/3/library/sys.html#sys.path https://docs.python.org/3/reference/datamodel.html#module.__file__
Plagman
force-pushed
the
bleeding-edge
branch
28 times, most recently
from
6c571a9 to
d066205
Compare
Plagman
force-pushed
the
bleeding-edge
branch
10 times, most recently
from
4146afd to
3c93b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually not set system-wide, but should be: PYTHONSAFEPATH disables the ability to import from the current working directory.
with PYTHONSAFEPATH enabled:
['/var/lib/...', ...]becomes[PROTON_DIR, '/var/lib/...', ...]without PYTHONSAFEPATH enabled:
[PROTON_DIR, '/var/lib/...', ...]becomes[PROTON_DIR, PROTON_DIR, '/var/lib/...', ...]The double entry should have the same effect as a single entry (enabling relative imports)
The relevant pieces in play:
https://docs.python.org/3/using/cmdline.html#envvar-PYTHONSAFEPATH
https://docs.python.org/3/library/sys.html#sys.path
https://docs.python.org/3/reference/datamodel.html#module.__file__
Testing done: in a session with PYTHONSAFEPATH=1 set in my ~/.config/environment.d folder: Games don't launch sometimes. If I add these lines, they launch. Have not tried to see if it causes any negative changes in a environment without PYTHONSAFEPATH set