[TF2] Fix player not being able to deploy parachute after landing and becoming airborne without jump button#735
Merged
EricS-Valve merged 4 commits intoValveSoftware:masterfrom May 12, 2025
Conversation
FlaminSarge
changed the title
FlaminSarge
force-pushed
the
parachute-deploy
branch
from
6c86a32 to
6e0699f
Compare
Contributor
Author
|
Alternative to "Don't allow activating parachute on ground": prevent ToggleParachute entirely when on the ground. However, this has the opportunity to introduce complications with parachute cond removal for halloween karts/etc., so limiting the behavior to preventing just activation is safer. |
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Feb 22, 2025
misyltoad
reviewed
Feb 25, 2025
Contributor
Author
|
As a heads up, I'm planning on a separate PR (very much WIP) that attempts to allow values of parachute_attribute greater than 1 to increase the number of times the parachute can be redeployed, for community projects to use/etc. Kinda like #772. |
FlaminSarge
force-pushed
the
parachute-deploy
branch
from
cf30783 to
2fd04ff
Compare
…ing airborne without jump button
…t removed on Think)
FlaminSarge
force-pushed
the
parachute-deploy
branch
from
2fd04ff to
e7de715
Compare
Bitl
added a commit
to BitlDevelopmentStudios/source-sdk-2013-bds-base
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ValveSoftware/Source-1-Games#2455
As described in above bug, TF_COND_PARACHUTE_DEPLOYED is not removed upon landing, but only upon using the jump button while grounded. This can lead to a case where the player has used the parachute, landed, and then becomes airborne without the jump button again, resulting in them being unable to deploy the parachute despite being fully grounded.
This patch moves the removal of the condition to the same case as TF_COND_PARACHUTE_ACTIVE's removal when grounded. It also prevents using the jump button to add the parachute conditions while grounded, in order to prevent the client from receiving the parachute condition for a frame every time they jump.