chore: add biome.json + apply formatter flag-day#25
Merged
Conversation
Caught during the eval.ts retirement PR: this repo has no formatter config, so running biome with defaults reformats files spaces→tabs. The eval-retire PR had to revert biome's default reformat to avoid shipping a 700-line stylistic blast. Adding a biome.json that matches the existing 2-space / double-quote / semicolon / trailing-comma convention, plus a one-shot `biome format --write` of the codebase so future biome runs are no-ops. Linter is disabled in the config (recommended ruleset finds ~63 errors in existing code — that's a separate cleanup decision). After this PR: - `npx @biomejs/biome format .` returns "No fixes applied" - `npm run build` clean, all 115 tests still pass - Any contributor running biome will get the same style without reformat conflicts Style choices locked in: - indent: 2 spaces (matches all existing files) - line width: 80 - quotes: double, semicolons: always - trailing commas: all - arrow parens: always
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
biome.jsonmatching the existing 2-space / double-quote / semicolon / trailing-comma convention.biome format --writeof the codebase so future biome runs are no-ops on a clean checkout.Style choices locked in:
Scope: chore. No behavior change, no test impact. Pure config + mechanical reformat.
Skipped pipeline stages:
planner/implementersplit skipped — user said "if it's easy, just toss it in" (explicit skip-planning carve-out).test-writerskipped — no new behavior to spec.code-reviewerskipped — mechanical formatter reformat is hand-reviewable in the diff (line breaks, trailing commas, multi-line type defs); semantically identical pre/post.Test plan