Add controlled keywords to score set search filter options.#702
Open
EstelleDa wants to merge 5 commits intorelease-2026.1.3from
Open
Add controlled keywords to score set search filter options.#702EstelleDa wants to merge 5 commits intorelease-2026.1.3from
EstelleDa wants to merge 5 commits intorelease-2026.1.3from
Conversation
bencap
approved these changes
Apr 21, 2026
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Looks great, thanks Estelle.
bencap
reviewed
Apr 21, 2026
Comment on lines
+219
to
+230
| if search.controlled_keywords: | ||
| for label in search.controlled_keywords: | ||
| query = query.filter( | ||
| ScoreSet.experiment.has( | ||
| Experiment.keyword_objs.any( | ||
| ExperimentControlledKeywordAssociation.controlled_keyword.has( | ||
| ControlledKeyword.label == label | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
| ) | ||
|
|
Collaborator
There was a problem hiding this comment.
Hmm, actually one thing that I noticed based on the front end. If a user searches for 'Other' (or any value which is ambiguous between keyword categories), all results will show up regardless of the intended class being searched. We may need to reqork the way that the controlled keyword search works to accept both a value and a key, similar to how you return both a value and a key. This would let us more precisely match the users' search request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.