SVG and PNG Downloads for Heatmap#255
Merged
bencap merged 9 commits intorelease-2024.3.0from Aug 27, 2024
Merged
Conversation
bencap
added
type: bug
This was
linked to
issues
Aug 26, 2024
Hides Selection Tooltip When No Bin is Selected: The previous version threw errors when selecting a heatmap square with no score, since this variant was not present in the histogram. Treat NaN Scores as Null: The previous version sent all such score averages to NaN. See #256 for further information.
bencap
force-pushed
the
feature/bencap/216/png-for-heatmap
branch
from
7d0d2f8 to
ed68fed
Compare
Adds a chart export lib module in support of this task. SVGs are handled with custom logic to allow for grouped export (in the heatmap, the chart is composed of two SVGs grouped within a scroll div). For PNGs, we use an external module as this conversion of composed SVGs was giving us trouble during PNG Rasterization.
bencap
force-pushed
the
feature/bencap/216/png-for-heatmap
branch
from
ed68fed to
3fe1683
Compare
jstone-dev
reviewed
Aug 27, 2024
Collaborator
|
The limitation of the export feature from the gastruloid site carries over here: In some browsers, clicking one of the download buttons just saves an SVG file instead of prompting the user for a location and image format (SVG or PNG). I think this is fine, though at some point we might want to look into it. It may be an effect of browser settings that we can't work around. |
Adds a new `exportChart` emits property to our chart components that emits the `exportChart` function handler once the component is mounted. The parent component grab this method object via the `@handler` hook on the child component and use the method without relying on manipulating child refs.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#216, plus rolls in changes from #251