Skip to content

Conversation

@jstone-dev
Copy link
Collaborator

[Re-merging the same changes as https://github.com//pull/476]

This pull request introduces new filtering and visualization options for protein variant effects in the histogram component, refactors some variant effect logic for reusability, and improves the UI controls for clinical and protein effect views. The most important changes are grouped below:

Variant Effect Filtering and Visualization:

  • Added support for filtering and visualizing histogram data by protein effect types (Missense, Synonymous, Nonsense, Start/Stop Loss, Other), including new UI controls for selecting these filters. This enables users to focus on specific protein variant effects in both clinical and protein effect views. [1] [2] [3] [4] [5]
  • Introduced a new "Protein Effect View" option in the histogram, allowing users to visualize variants grouped by protein effect. [1] [2]

Refactoring and Code Reuse:

  • Moved the isStartOrStopLoss logic to a shared location (@/lib/variants) and updated both heatmap and histogram components to use the new function, reducing code duplication and improving maintainability. [1] [2] [3] [4] [5]
Screenshot 2025-09-26 at 10 57 54 AM

Clinical Mode and Customization Improvements:

  • Added clinicalModeActive prop and logic to control which variant effect filters are available, ensuring that Start/Stop Loss variants are excluded in clinical mode where appropriate. [1] [2] [3]
  • Updated custom and clinical views to apply protein effect filters to control variants, allowing for more granular filtering of clinical significance series. [1] [2] [3] [4]

User Interface Enhancements:

  • Improved UI controls by grouping options into fieldsets with clear legends, enhancing usability and organization of clinical and protein effect series options. [1] [2] [3]
  • Updated labels and layout for variant effect and clinical significance controls for clarity and consistency.
Screenshot 2025-09-26 at 10 58 21 AM

Reactivity and State Management:

  • Added watchers for new filter properties and clinical mode to ensure the histogram updates automatically when options change, improving responsiveness and user experience. [1] [2]

@jstone-dev jstone-dev merged commit 61b9297 into release-2025.4.1 Sep 27, 2025
@jstone-dev jstone-dev deleted the jstone-dev/heatmap-cleanup branch September 27, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants