Overlapping Histogram Labels #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sibility Adds a new property `renderShaderTitles` accessor to control shader title visibility. This property has three settings: `show`, `hide`, and `auto`: - `show`: Always shows the shader title - `hide`: Always hides the shader title - `auto`: Calculates the width of the range shader and title text box. If the width of the text is wider than the width of the shader, don't display it. Otherwise, display the title text.
… a pre-selected datum
…nd variants In support of these classification labels, adds a new function for detecting overlap of bins and shader regions. Opens #491 as an enhancement to this solution.
…dded with a datum selected When a datum was selected in a series index larger than the length of the prior list of series options, the histogram was attempting to select from a undefined series. Fix this issue by refreshing the histogram prior to selecting the datum.
Collaborator
Author
|
To be merged with release-2025.4.2. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the display and logic of range classifications in the histogram component, focusing on how range classification badges are shown in tooltips and on the chart itself. It introduces improved handling for overlapping shader ranges, configurable rendering of shader titles, and clearer visual presentation of classification information.
Histogram Tooltip & Classification Badge Improvements
.mavedb-range-classification-badgefor consistent styling of these badges in tooltips.Shader Range Logic & Utilities
shaderOverlapsBinutility to determine if a shader range overlaps a histogram bin, treating both as half-open intervals and handling unbounded ranges. This function is now used in tooltip logic and exported for reuse.Histogram Rendering Options
renderShaderTitlesproperty and accessor toHistogramobjects, allowing titles to be shown, hidden, or automatically hidden if they do not fit within their region. The rendering logic in the chart was updated to respect this setting. [1] [2] [3] [4]Range Labeling