Skip to content

Add PropositionalFormulaParserTest#132

Merged
pmbittner merged 2 commits intoVariantSync:developfrom
maximilian-glumann:issue104-propositional-formula-parser-test
Mar 21, 2024
Merged

Add PropositionalFormulaParserTest#132
pmbittner merged 2 commits intoVariantSync:developfrom
maximilian-glumann:issue104-propositional-formula-parser-test

Conversation

@maximilian-glumann
Copy link
Copy Markdown

@maximilian-glumann maximilian-glumann commented Feb 14, 2024

resolves #104

@maximilian-glumann maximilian-glumann marked this pull request as ready for review February 14, 2024 12:48
@pmbittner pmbittner self-requested a review February 14, 2024 15:38
@pmbittner pmbittner added the enhancement New feature or request label Feb 14, 2024
@pmbittner pmbittner linked an issue Feb 14, 2024 that may be closed by this pull request
Copy link
Copy Markdown
Member

@pmbittner pmbittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maximilian-glumann

thank you, the changes look great. Only some minor comments regarding the documentation. We can discuss these comments tomorrow in our meeting. Then we can merge. :)

Comment thread src/test/java/PropositionalFormulaParserTest.java
Comment thread src/test/java/PropositionalFormulaParserTest.java Outdated
Comment thread src/test/java/PropositionalFormulaParserTest.java Outdated
@maximilian-glumann maximilian-glumann force-pushed the issue104-propositional-formula-parser-test branch from fb11b73 to 4ab8d21 Compare March 20, 2024 17:32
@pmbittner pmbittner merged commit 56abb9c into VariantSync:develop Mar 21, 2024
@maximilian-glumann maximilian-glumann deleted the issue104-propositional-formula-parser-test branch April 23, 2024 21:36
@pmbittner pmbittner mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

Test Propositional Formula Parser

2 participants