Conversation
pmbittner
reviewed
Sep 13, 2022
Member
pmbittner
left a comment
pmbittner
left a comment
There was a problem hiding this comment.
Changes look very good. Proceed as discussed.
ibbem
force-pushed
the
benjamin/tikz
branch
2 times, most recently
from
899a0c4 to
3347f15
Compare
ibbem
force-pushed
the
benjamin/tikz
branch
from
3347f15 to
8ed6488
Compare
pmbittner
requested changes
Sep 21, 2022
Member
pmbittner
left a comment
pmbittner
left a comment
There was a problem hiding this comment.
Only minor changes. Looks very good!
The layout is computed using Graphviz.
Line graph specific export code is moved to the line graph exporter. This changes the line endings to use the OS dependent representation through the use of `PrintStream`. Currently there is an unnecessary conversion from `String` to `ByteArray` and back because `OutputStream`s are used. This will be optimised in the future by directly outputting to the desired devices (file and terminal) without converting back to a `String` representation.
ibbem
force-pushed
the
benjamin/tikz
branch
from
8ed6488 to
3a17a78
Compare
Collaborator
Author
|
All requested changes are done now. |
pmbittner
approved these changes
Sep 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.