Reorganize long-running service rules into lifecycle structure#50
Reorganize long-running service rules into lifecycle structure#50
Conversation
Restructure "Long-Running Service Reuse" into "Long-Running Process Lifecycle" with three phases: Before Starting, Reuse vs Restart, Before Stopping. Add rule requiring user confirmation before killing any long-running process. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the CLAUDE.md guide to refine the lifecycle management of long-running processes, emphasizing user confirmation before stopping or killing instances. The changes restructure the process detection logic and clarify the 'Reuse vs Restart' decision-making process. Review feedback pointed out logical contradictions between the general requirement for confirmation and cases where a user explicitly requests a restart; suggestions were made to unify these rules and avoid redundant confirmation prompts.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4ef23be8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Reuse vs Restart now defers to Before Stopping rules instead of defining its own kill policy. Before Stopping consolidates to two clear cases: explicit user instruction (no confirmation needed) vs everything else (confirmation required). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 participant
Summary
Test plan
Applies toandBefore Stopping🤖 Generated with Claude Code