Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| c.stderrPipe = stderrWriter | ||
| c.origStdout = os.Stdout | ||
| c.origStderr = os.Stderr | ||
|
|
||
| os.Stdout = stdoutWriter |
There was a problem hiding this comment.
The desktop console only redirects stdout and stderr (c.origStdout, c.origStderr, and os.Stdout/os.Stderr are swapped here) but leaves os.Stdin untouched. Commands such as session add and ssh still call utils.Prompt/PromptPassword, which read from stdin. After the old terminal loop was removed, there is no way to respond to these prompts inside the window, so those commands block waiting on terminal input and the UI appears frozen. The console should capture stdin or surface prompt dialogs so interactive commands remain usable.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| c.stderrPipe = stderrWriter | ||
| c.origStdout = os.Stdout | ||
| c.origStderr = os.Stderr | ||
|
|
||
| os.Stdout = stdoutWriter |
There was a problem hiding this comment.
The desktop console only redirects stdout and stderr (c.origStdout, c.origStderr, and os.Stdout/os.Stderr are swapped here) but leaves os.Stdin untouched. Commands such as session add and ssh still call utils.Prompt/PromptPassword, which read from stdin. After the old terminal loop was removed, there is no way to respond to these prompts inside the window, so those commands block waiting on terminal input and the UI appears frozen. The console should capture stdin or surface prompt dialogs so interactive commands remain usable.
Useful? React with 👍 / 👎.
VectoDE
deleted the
codex/create-standalone-console-window-for-servercommander-3ntuuv
branch
1 participant
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f7b700f248832caaebf128532d6d5c