Retype virtual functions from RTTI

[emesare]

Currently virtual functions are not retyped, either in the virtual function table, or in the actual backing function type (i.e. the pointed to function). This means that we do not annotate __thiscall or provide the implicit this param.

Adding the implicit this param will require understanding of the virtual function ownership, if two or more virtual function tables point to a function we must determine which "owns" the function. This is not always possible as functions which are deduplicated will not have a clear hierarchy so we must be conservative in our ownership assignment.

[jduck]

This was one of the things on my list of pain points. The missing this parameter is confusing to me and leads to incorrect analysis inside the functions. The workaround I came up with is just to manually modify the prototype of an affected function.