Skip to content

Refactor integer token generation. #6528

@loadlibraryninja

Description

@loadlibraryninja

Version and Platform (required):

  • Binary Ninja Version: 4.3.7099-dev (7abaf025)
  • OS: Ubuntu Linux
  • OS Version: 24.10
  • CPU Architecture: x64

Bug Description:
In the same function sometimes a constant is show as a unsigned hex and other times it's shown as a signed hex constant - this makes using the highlight feature impossible.

Steps To Reproduce:

  1. Load: proud bird swims carefully
  2. Go to: 0x10004a02 (llil representation) notice the value stored ebx is an unsigned hex value
  3. It matches the value in il index 26 but that value is a signed hex value. This make using the highlight feature to quickly find the corresponding match unusable.

Expected Behavior:
Could either the same representation (signed/unsigned) be used or (better yet) could the highlight function also take in consideration the various representations that are equal to each other? Yes, I could manually change the representation, but as you can tell from the looking at this binary that becomes time consuming.

Screenshots/Video Recording:

Binary:
proud bird swims carefully

Additional Information:

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: CoreIssue needs changes to the coreEffort: LowIssues require < 1 week of workImpact: MediumIssue is impactful with a bad, or no, workaround
    No fields configured for Enhancement.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions