Skip to content

WARP doesn't save varargs status of functions #7929

@CouleeApps

Description

@CouleeApps

Version and Platform (required):

  • Binary Ninja Version: 5.3.9003-dev
  • Edition: Ultimate
  • OS: macOS
  • OS Version: 26.2
  • CPU Architecture: aarch64

Bug Description:
When I used WARP to save signatures for printf, and then used those signatures to match printf in a new file, the varargs portion of the arguments to printf was not applied. Notably, it gave printf the signature void printf(char* format); missing the varargs. The varargs are a critical part of the type signature, as they indicate to analysis that the remaining arguments (at least in my architecture's case) are passed via the stack and not registers.

Steps To Reproduce:

  1. Open a stripped binary containing printf
  2. Navigate to printf
  3. Name and type printf as void printf(char* format, ...);
  4. Use WARP > Include Function to mark printf for export
  5. WARP > Create > From Current View and set included functions to Selected
  6. WARP > Load File on the generated signatures you just saved
  7. Re-open stripped binary
  8. Observe printf is detected but now has the signature void printf(char* format); with no varargs

Expected Behavior:
I expected the function signature I specified to be saved as-is and for the varargs to be reapplied.

Additional Information:
Signatures were generated for a binary using a custom arch plugin which can be provided if requested

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: WARPImpact: LowIssue is a papercut or has a good, supported workaround

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions