[ARM64] Fix lifting of tbz / tbnz for bits >= 32#7209
Merged
Conversation
plafosse
approved these changes
Jul 30, 2025
plafosse
left a comment
Member
There was a problem hiding this comment.
I looked at this this morning and identified this as the problem too. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7205.
Since the integer literal
1fits in an int, that is its type. Shifting it by values larger than 31 give unexpected behavior in this context. I'm not entirely sure how we get0xffffffff80000000as the result. That doesn't match my reading of https://en.cppreference.com/w/cpp/language/operator_arithmetic.html#Built-in_bitwise_shift_operators. Prior to C++20 this was undefined behavior territory, but with C++20 it should be well defined.The fix is to ensure that the value we are shifting is a
uint64_t.