Skip to content

Conversation

@markos
Copy link

@markos markos commented Jan 17, 2024

Another pass in cleaning up the code:

  • Remove all warnings from compilation
  • Make the compilation stricter by adding -Werror and keeping only the most necessary exceptions for compiler warnings.
  • Make some fixes in the x86 builds

@markos markos linked an issue Jan 17, 2024 that may be closed by this pull request
@markos markos marked this pull request as ready for review January 20, 2024 20:34
@markos markos merged commit 98eb459 into develop Jan 20, 2024
@markos
Copy link
Author

markos commented Jan 20, 2024

According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project.

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.

@markos markos changed the title WIP: Feature/cleanup compiler warnings Feature/cleanup compiler warnings Jan 20, 2024
@markos markos deleted the feature/cleanup-compiler-warnings branch May 22, 2024 09:35
markos added a commit that referenced this pull request Oct 24, 2025
…ings

According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project. 

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.
markos added a commit that referenced this pull request Oct 24, 2025
…ings

According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project. 

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.
markos added a commit that referenced this pull request Oct 24, 2025
…ings

According to https://buildbot-ci.vectorcamp.gr/#/changes/93

most builds succceded and with no compiler warnings. The build failures were only on x86 and Arm for SIMDe builds: x86 because of a bug in SIMDe emulation of own x86 intrinsics in non-native mode and Arm due to clang, unsure if this is actually a bug in SIMDe or clang itself. All the remaining compiler warnings that were suppressed was because they were not possible to fix for the scope of this project. 

This PR will close #170, code quality improvements however will continue with the integration of #222 or similar static code analyzer to CI and continuous refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve code quality

2 participants