Skip to content

Conversation

@isildur-g
Copy link

addressing cppcheck shadowFunction warnings, no false positives.
Closes some: #252

@markos
Copy link

markos commented May 6, 2024

One occurence seems to still be there:

https://buildbot-ci.vectorcamp.gr/#/builders/278/builds/33/steps/5/logs/stdio

/var/lib/buildbot/workers/runner-d13-ppc64le-01/release-linux-ppc64le-gcc-14-cppcheck/source/src/rose/rose_build_add_mask.cpp:305:15: style: Local variable 'preds' shadows outer function [shadowFunction]
    NFAVertex preds = anchored ? lhs->start : lhs->startDs;

markos
markos previously approved these changes May 9, 2024
Copy link

@markos markos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved.

Copy link

@markos markos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markos markos merged commit cd1e13d into VectorCamp:develop May 10, 2024
markos added a commit that referenced this pull request Oct 24, 2025
addressing cppcheck shadowFunction warnings
markos added a commit that referenced this pull request Oct 24, 2025
addressing cppcheck shadowFunction warnings
markos added a commit that referenced this pull request Oct 24, 2025
addressing cppcheck shadowFunction warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants