Wip cppcheck271 useStlAlgorithm part2 #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markos
reviewed
May 17, 2024
markos
reviewed
May 17, 2024
markos
reviewed
May 17, 2024
markos
reviewed
May 17, 2024
markos
reviewed
May 17, 2024
markos
approved these changes
May 21, 2024
markos
left a comment
markos
left a comment
There was a problem hiding this comment.
I'm still unsure about useStlAlgorithm's usefulness tbh, but approving and we can revisit during refactoring.
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Wip cppcheck271 useStlAlgorithm part2
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Wip cppcheck271 useStlAlgorithm part2
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Wip cppcheck271 useStlAlgorithm part2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is part 2 of the useStlAlgorithm cppcheck warnings.
Most of these are simply comments to ignore the warning, as in almost all
cases replacing a simple operation with a function call will kill performance and make
clear to understand code more muddled.
we did use it in most of the instances of copy, fill, and accumulate.
Closes some: #252