Fix Clang Tidy warnings #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markos
reviewed
May 30, 2024
markos
reviewed
May 30, 2024
markos
reviewed
May 30, 2024
Merged
markos
added a commit
that referenced
this pull request
Jul 22, 2025
Multiple changes since last release, this will be the last 100% ABI and API compatible with Hyperscan release. Next versions will include major refactors and API extensions, it will be mostly backwards compatible however. Without particular order, platform support is now: * Linux (x86, Arm, Power) * FreeBSD 14 (x86, Arm, Power) * MacOS 14+ (x86, Arm) In total more than 200 configurations in the CI are tested for every PR. Other features: - Fat Runtime supported for Arm as well (ASIMD/SVE/SVE2). - Initial implementations for Arm SVE/SVE2 algorithms added, thanks to Yoan Picchi from Arm. - SIMDe support added, used as an alternative backend for existing platforms, but mostly interesting for allowing Vectorscan to build in new platforms without a supported SIMD engine. - Various speedups and optimizations. - Cppcheck and clang-tidy fixes throughout the code, both have been added to CI for multiple configurations, but only cppcheck triggers a build failure for now. Various bugfixes, most important listed: - Speed up truffle with 256b TBL instructions (#290) - Fix Clang Tidy warnings (#295) - Clang 17+ is more restrictive on rebind<T> on MacOS/Boost, remove warning (#332) - partial_load_u64 will fail if buf == NULL/c_len == 0 (#331) - Bugfix/fix avx512vbmi regressions (#335) - fix missing hs_version.h header (closes #198) - hs_valid_platform: Fix check for SSE4.2 (#310) - Fixed out of bounds read in AVX512VBMI version of fdr_exec_fat_teddy … (#333) - Fix noodle SVE2 off by one bug (#313) - Make vectorscan accept \0 starting pattern (#312) - Fix 5.4.11's config step regression (#327) - Fix double shufti's vector end false positive (#325)
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Fixes some of the clang-tidy warnings clang-analyzer-deadcode.DeadStores clang-analyzer-cplusplus.NewDelete clang-analyzer-core.uninitialized.UndefReturn closes some:#253 ignored in this pr: /usr/include/boost/smart_ptr/detail/shared_count.hpp:432:24 /usr/include/boost/smart_ptr/detail/shared_count.hpp:443:24 51 in build/src/parser gtest ones src/fdr/teddy_compile.cpp:600:5 refactoring on way src/fdr/fdr_compile.cpp:209:5 refactoring on way
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Fixes some of the clang-tidy warnings clang-analyzer-deadcode.DeadStores clang-analyzer-cplusplus.NewDelete clang-analyzer-core.uninitialized.UndefReturn closes some:#253 ignored in this pr: /usr/include/boost/smart_ptr/detail/shared_count.hpp:432:24 /usr/include/boost/smart_ptr/detail/shared_count.hpp:443:24 51 in build/src/parser gtest ones src/fdr/teddy_compile.cpp:600:5 refactoring on way src/fdr/fdr_compile.cpp:209:5 refactoring on way
markos
added a commit
that referenced
this pull request
Oct 24, 2025
Fixes some of the clang-tidy warnings clang-analyzer-deadcode.DeadStores clang-analyzer-cplusplus.NewDelete clang-analyzer-core.uninitialized.UndefReturn closes some:#253 ignored in this pr: /usr/include/boost/smart_ptr/detail/shared_count.hpp:432:24 /usr/include/boost/smart_ptr/detail/shared_count.hpp:443:24 51 in build/src/parser gtest ones src/fdr/teddy_compile.cpp:600:5 refactoring on way src/fdr/fdr_compile.cpp:209:5 refactoring on way
markos
added a commit
that referenced
this pull request
Oct 29, 2025
Multiple changes since last release, this will be the last 100% ABI and API compatible with Hyperscan release. Next versions will include major refactors and API extensions, it will be mostly backwards compatible however. Without particular order, platform support is now: * Linux (x86, Arm, Power) * FreeBSD 14 (x86, Arm, Power) * MacOS 14+ (x86, Arm) In total more than 200 configurations in the CI are tested for every PR. Other features: - Fat Runtime supported for Arm as well (ASIMD/SVE/SVE2). - Initial implementations for Arm SVE/SVE2 algorithms added, thanks to Yoan Picchi from Arm. - SIMDe support added, used as an alternative backend for existing platforms, but mostly interesting for allowing Vectorscan to build in new platforms without a supported SIMD engine. - Various speedups and optimizations. - Cppcheck and clang-tidy fixes throughout the code, both have been added to CI for multiple configurations, but only cppcheck triggers a build failure for now. Various bugfixes, most important listed: - Speed up truffle with 256b TBL instructions (#290) - Fix Clang Tidy warnings (#295) - Clang 17+ is more restrictive on rebind<T> on MacOS/Boost, remove warning (#332) - partial_load_u64 will fail if buf == NULL/c_len == 0 (#331) - Bugfix/fix avx512vbmi regressions (#335) - fix missing hs_version.h header (closes #198) - hs_valid_platform: Fix check for SSE4.2 (#310) - Fixed out of bounds read in AVX512VBMI version of fdr_exec_fat_teddy … (#333) - Fix noodle SVE2 off by one bug (#313) - Make vectorscan accept \0 starting pattern (#312) - Fix 5.4.11's config step regression (#327) - Fix double shufti's vector end false positive (#325)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the clang-tidy warnings
clang-analyzer-deadcode.DeadStores
clang-analyzer-cplusplus.NewDelete
clang-analyzer-core.uninitialized.UndefReturn
closes some:#253
ignored in this pr:
/usr/include/boost/smart_ptr/detail/shared_count.hpp:432:24
/usr/include/boost/smart_ptr/detail/shared_count.hpp:443:24
51 in build/src/parser
gtest ones
src/fdr/teddy_compile.cpp:600:5 refactoring on way
src/fdr/fdr_compile.cpp:209:5 refactoring on way