Fixing an issue with Opacus modified models and optimizers. #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not DP compliant and the parameters have misalignment in the optimizer. Also adding in an example of "safely" setting the server initial parameters.
emersodb
commented
Mar 18, 2024
| ) | ||
|
|
||
|
|
||
| def get_model_and_validate() -> nn.Module: |
Collaborator
Author
There was a problem hiding this comment.
Note: This model wasn't causing any problems, but I wanted the examples to reflect a situation where the server should pass the appropriate model parameters after validation and correction to ensure that all the model weights line up properly
emersodb
commented
Mar 18, 2024
| # Currently uses the Pytorch default initialization for the model parameters. | ||
| initial_model = MnistNet() | ||
| initial_model: nn.Module = MnistNet() | ||
| initial_model, _ = privacy_validate_and_fix_modules(initial_model) |
Collaborator
Author
There was a problem hiding this comment.
Note: This model wasn't causing any problems, but I wanted the examples to reflect a situation where the server should pass the appropriate model parameters after validation and correction to ensure that all the model weights line up properly
zxj-c
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Addressing an issue that can arise when opacus replaces layers that are not DP compliant and the parameters have misalignment in the optimizer. Also adding in an example of "safely" setting the server initial parameters..
Tests Added
Added a few tests to ensure that the functionality is indeed replacing the desired layers and that the new layers are also being replaced in the optimizer itself.