Displaying all the smoke tests metrics errors at once #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
approved these changes
Mar 22, 2024
Collaborator
emersodb
left a comment
emersodb
left a comment
There was a problem hiding this comment.
I imagine this fix is because of how much you enjoyed fixing smoke test issues on your FedDG-GA PR 😂. Looks good to me.
Collaborator
Author
|
@emersodb lol exactly, I ended that day thinking "there's gotta be a better way of doing this" 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Fix
Short Description
Clickup Ticket(s): NA
Fixing smoke tests metric errors is a pain because they are displayed one by one. Changing it here to display all of them at once to avoid multiple iterations of fixing them.
Tests Added
NA