Skip to content

Conversation

@amrit110
Copy link
Member

@amrit110 amrit110 commented Jan 27, 2023

PR Type

Packaging

Short Description

  • This PR adds a github action workflow that automatically packages the repo and pushes the package to PyPI. The PyPI API token needs to be added to the repo's settings.
  • Also updates the pyproject.toml to use poetry for dependency management. When package is built, only the main dependencies are included, not the dev and codestyle dependencies. The poetry.lock file essentially locks all the dependencies so that the entire virtual environment is freezed and is reproducible.

Tests Added

None

@amrit110 amrit110 requested a review from emersodb January 27, 2023 17:49
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions:

  1. Should we put a comment in the readme about the Poetry release flow?
  2. Is there a way to check that an individual has bumped the version number before publishing?

@emersodb emersodb merged commit 3350845 into main Jan 27, 2023
@emersodb emersodb deleted the add_packaging branch January 27, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants