Enable pre-commit ci and add default config #132
Conversation
|
Currently failing due to pip-audut check. Posted an update which would fix that #133 |
|
@amrit110: pip-audit whack-a-mole going on here 😂. Feel free to just include the fix/ignores in this PR |
| autoupdate_branch: '' | ||
| autoupdate_commit_msg: '[pre-commit.ci] pre-commit autoupdate' | ||
| autoupdate_schedule: weekly | ||
| skip: [mypy] |
There was a problem hiding this comment.
Should we add tests to the skip list too? I think the goal of this is to perform the auto-corrections from black, isort and such, right? Please correct me if I'm wrong.
We should definitely skip the smoke tests, though, or this will take a long time to finish (and also because of that flakiness that is still happening sometimes, albeit a bit rarely).
There was a problem hiding this comment.
Oh I see, there are no tests in the pre-commit for this repo. Approving :)
There was a problem hiding this comment.
Do you think we should have tests in the pre-commit (would be a different PR)? I didn't include them, because I didn't necessarily want to preclude people from intermediate (but test breaking) commits. However, I could be convinced that was not a good idea 😂.
There was a problem hiding this comment.
I think it's a good idea if the tests are fast to run. The Florist unit tests are super fast (maybe because there are not that many yet) so I included them, but left the integration tests out.
PR Type
[Feature | Fix | Documentation | Other ]
CI
Short Description
Clickup Ticket(s): Link(s) if applicable.
Add a short description of what is in this PR.
Tests Added
Describe the tests that have been added to ensure the codes correctness, if applicable.