Skip to content

Conversation

@jewelltaylor
Copy link
Contributor

PR Type

[Feature | Fix | Documentation | Other ]

Short Description

Clickup Ticket(s): Initial nnUNet Integration for PICAI research

This PR does some initial work to leverage the nnUNet framework in FL4Health. This includes:

  • Moving preprocessing into the repo so that we have the flexibility to produce preprocessed datasets in the format that nnUNet expects.
  • Run preprocessing on raw dataset on cluster to produce desired dataset on cluster. Remove old datasets.
  • Update the existing FL and central examples to use the new dataset format.
  • Add scripts to train nnUNet on the Whole Gland Segmentation task. One script to train from scratch on PICAI dataset. Another script to finetune a model already trained on a private dataset in the Haider Lab.
  • Update scripts to requeue if they are still running when they timeout (previously a huge issue since training always takes longer than max job time)
  • Update documentation in the picai research folder to include the new functionality

In following tickets I will:

  • Do some initial experiments to establish some baselines.
  • More sophisticated data augmentation pipeline, possibly borrowed from nnUNet, to apply to current central and FL examples.
  • Integrate architecture and training pipeline configuration from nnUNet to the federated setting.

Tests Added

Since a lot of this is research code and subject to change, I have not included tests. However, let me know if you think there are any tests that would be useful.

…es along with corresponding wg segmentation labels
… cancerous lesion segmentation. Update README with new details of the wg segmentation dataset on the cluster.
…s to dataset overview for compatibility with existing central and FL examples which use it to define focal loss
…ate loading for central and fl examples. Add documentation for nnUNet scripts. Few other smaller changes
…ove scripts to run on different nodes. Update documentation.
@jewelltaylor jewelltaylor changed the title Nnunet picai nnUNet picai May 21, 2024
@jewelltaylor jewelltaylor changed the title nnUNet picai nnUNet PICAI May 21, 2024
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think all the additions look awesome. Just some fairly straightforward comments. I didn't fully check the correctness of the preprocessing calculations, because that's pretty challenging without examples. So I'll assume you have already verified their "correctness"

@jewelltaylor jewelltaylor requested a review from emersodb May 30, 2024 19:06
Copy link
Collaborator

@emersodb emersodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor typo type comments. Good to go otherwise.

@jewelltaylor jewelltaylor merged commit de604c6 into main May 30, 2024
@jewelltaylor jewelltaylor deleted the nnunet-picai branch May 30, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants