PR4: Add deep_mmd_loss files #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sanaAyrml merged 22 commits into main from sa_add_deep_mmd_loss

Oct 22, 2024

Collaborator

sanaAyrml commented Jun 7, 2024

PR Type

[Feature]

Short Description

This is a tentative implementation for deep mmd loss.

Tests Added

No tests added yet.

sanaAyrml requested a review from emersodb

June 7, 2024 06:38

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

emersodb reviewed

View reviewed changes

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

sanaAyrml and others added 2 commits

September 17, 2024 14:47


          Rename some variables

f961823


          [pre-commit.ci] Add auto fixes from pre-commit.com hooks

4df87e3

for more information, see https://pre-commit.ci

sanaAyrml changed the base branch from sa_update_mkmmd_loss to sa_add_cifar10_experiments

September 17, 2024 18:54

sanaAyrml added 2 commits

September 17, 2024 15:00


           change order of PRs

3fc0d4c


          re-add deep mmd files

8c0377f

sanaAyrml changed the title ~~PR3: Add deep_mmd_loss files~~ PR4: Add deep_mmd_loss files

Base automatically changed from sa_add_cifar10_experiments to main

October 7, 2024 16:52

sanaAyrml and others added 12 commits

October 9, 2024 15:24


          Merge branch 'main' into sa_add_deep_mmd_loss

ac393ba


          Address David's comments and clean the code

d2cc251


          Merge branch 'main' into sa_add_deep_mmd_loss

a064471


          Add comments to deep MMD loss function

2aab6e1


          Fix some comments

b778332


          [pre-commit.ci] Add auto fixes from pre-commit.com hooks

74c93e2

for more information, see https://pre-commit.ci


          Resolve the rest of comments on research folder


          check smoke tests

c8f04a9


          Fix errors in runing scripts

83256bd


          Add test for deep mmd loss

61b4917


          Change default of optimization steps

5b9e913


          Solve encountered loop in grdiants graph in mkmmd loss when Betas do …

…not get updated

sanaAyrml requested a review from emersodb

October 16, 2024 15:07

emersodb reviewed

View reviewed changes

Collaborator

emersodb left a comment

Really nice changes. Just added a few small comments and reminders of a few pieces you might have overlooked in my comments. Very close to ready to go!

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

fl4health/clients/deep_mmd_clients/ditto_deep_mmd_client.py Outdated Show resolved Hide resolved

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

fl4health/losses/deep_mmd_loss.py Show resolved Hide resolved

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

fl4health/losses/deep_mmd_loss.py Outdated Show resolved Hide resolved

sanaAyrml and others added 4 commits

October 17, 2024 14:32


          Address final comments

9abad1c


          [pre-commit.ci] Add auto fixes from pre-commit.com hooks

d84a4aa

for more information, see https://pre-commit.ci


          Loss computation refactor

7653f77


          Refactor mkmmd ditto and mrmtl

c163c04

emersodb approved these changes

View reviewed changes

Collaborator

emersodb left a comment

I think this looks ready to go!

I think the only open question we still have is how we get around that exception with the repeated backward call.

sanaAyrml added 2 commits

October 22, 2024 12:27


          Merge branch 'main' into sa_add_deep_mmd_loss

652f82b


          Add detach to betas

b951d6c

sanaAyrml merged commit a5e47aa into main

sanaAyrml deleted the sa_add_deep_mmd_loss branch

October 22, 2024 18:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet