Fix some bugs that slipped through in CR and trying to make type chec… #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
reviewed
Jun 14, 2024
| annotation_path = Path(os.path.join(annotation_read_dir, annotation_filename)) | ||
| annotation_base_filename = annotation_path.stem | ||
| # split on filename instead of stem on path since extension can have multiple "." in it. | ||
| annotation_base_filename = annotation_filename.split(".")[0] |
Collaborator
There was a problem hiding this comment.
Interesting. Path has a "suffixes" functionality, that handles grabbing multiple "suffixes" when they exist, but stem doesn't handle that nor is there an obvious function that does 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ker shutup
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Nice job @scarere for already finding some bugs!
Small changes to address indexing we are indexing into lists of args from parser (instead of tuples) and to resolve an issue called by using stem when extensions may have multiple "." in them. Was able to run the preprocessing on the cluster so can confirm it works.
Tests Added
NA