Fix picai channel ordering #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
reviewed
Jun 18, 2024
emersodb
reviewed
Jun 18, 2024
emersodb
reviewed
Jun 18, 2024
emersodb
reviewed
Jun 18, 2024
emersodb
approved these changes
Jun 18, 2024
Collaborator
emersodb
left a comment
emersodb
left a comment
There was a problem hiding this comment.
Fix and test looks good! Just some basic suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[Feature | Fix | Documentation | Other ]
Short Description
Clickup Ticket(s): Fix Picai Channel Ordering
The channel of the scans (t2w, adc, hbv) are being written with incorrect file names. The root of the cause was the write method of PicaiCase. The scan paths were being sorted when they should not. They are being passed with an assumed order. I also added to the documentation to make this more clear.
Tests Added