Adding in synthetic dataset generators based on the original FedProx paper #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
requested review from
fatemetkl,
jewelltaylor,
sanaAyrml and
scarere
fatemetkl
approved these changes
Sep 25, 2024
Collaborator
fatemetkl
left a comment
fatemetkl
left a comment
There was a problem hiding this comment.
LGTM! Just some minor comments/questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Clickup Ticket(s): Link
This small PR implements synthetic dataset generators based on the original FedProx paper. These generators are to be used in future experiments and replication studies. There are a few small modifications to how the generation takes place, but most of the process is inspired by the original implementation.
Note: These synthetic datasets end up with pretty skewed labels, which is a bit disappointing. See the tests for additional illustration. However, they will still be useful. It's just something to be aware of.
Tests Added
Several tests are implemented to check correctness of both generators (IID, non-IID)